opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
39 stars 18 forks source link

[Bug]: segfault in s1_geocode_slc with split_spectrum and dual/cross_pol #86

Closed LiangJYu closed 1 year ago

LiangJYu commented 1 year ago

Checked for duplicates

Yes - I've already checked

Describe the bug

When s1_geocode_slc is ran with split_spectrum enabled and polarization set to either dual_pol or cross_pol a segfault occurs.

What did you expect?

I expected it to not segfault

Reproducible steps

1. enable split spectrum in runconfig
2. set polarization to dual_pol or cross_pol in runconfig
3. run s1_geocode_slc with runconfig modified as described above

Environment

- PR#84
LiangJYu commented 1 year ago

When split spectrum is enabled in compass.s1_geocode_slc, a 3 layer raster is passed to isce3.geocode.geocodeSlc. isce3.geocode.geocodeSlc crashes because compass.s1_geocode_slc does not allocate 3 geocoded rasters in the HDF5 (only 1 is allocated).

@hfattahi @vbrancat When split spectrum is enabled, are all 3 rasters generated here to be geocoded?

vbrancat commented 1 year ago

@LiangJYu yes, when split-spectrum is enabled, we need to geocode all 3 SLCs (main, low, and side band). They should be allocated as separate layers inside the product (e.g. VV_low_band, VV_high_band). Also, most likely, when we have the dual-polmode enabled, we do not want to split the spectrum for both polarizations but only for the co-pol channel.

vbrancat commented 1 year ago

Closing since we have removed the split-spectrum from CSLC generation