opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
39 stars 18 forks source link

Solid Earth Tides correction #91

Closed vbrancat closed 1 year ago

vbrancat commented 1 year ago

This PR adds the Solid Earth Tides (SET) to the list of Look UP Table (LUT) corrections given to the geocodeSlc cor module. SET are computed using pySolid. The generated LUT in radar coordinates along slant range and azimuth are also added to the CSLC product.

Note that pySolid is not added as a dependency as the next isce3 conda release should already support this dependency.

scottstanie commented 1 year ago

A separate question I thoguht of: Is there any plan to separately save the corrections we apply (so a user could un-apply one of geometrical_steer_doppler, bistatic_delay, az_fm_mismatch, tides), or are we just saving the cumulative one?

vbrancat commented 1 year ago

The azimuth component of the SET is also in meters and it needs to be converted to seconds to be ingested by the geocoding core module. I realized that when I call the en2az function I messed up the sign of the heading angle.

vbrancat commented 1 year ago

A separate question I thoguht of: Is there any plan to separately save the corrections we apply (so a user could un-apply one of geometrical_steer_doppler, bistatic_delay, az_fm_mismatch, tides), or are we just saving the cumulative one?

The individual corrections are saved separately inside the product in the corrections group.

vbrancat commented 1 year ago

I think I have addressed all your comments. I would appreciate if you all can have another look at the PR. In the meantime, @seongsujeong is working on addressing the conversion of the azimuth component of SET from meters to seconds.