search

opera-adt / DSWX-SAR

Dynamic Surface Water Extent from Synthetic Aperture Radar
Apache License 2.0
9 stars 6 forks source link

Fix algorithmic bugs in filling gaps in the open water and in mosaicking images. #50

Closed oberonia78 closed 6 months ago

oberonia78 commented 6 months ago

During the testing of the algorithm, two issues were identified. The first issue arises when mosaicking images with different EPSG codes; the algorithm fails due to discrepancies in spatial extents and resolutions. To address this, the proposed change (PR) resamples the images by assigning the appropriate EPSG codes and rounded spatial extents.

The second issue concerns the 'Filling Gap Water' function used in refine_with_bimodality.py to fill gaps in open water areas. This function was not working correctly, but the issue has now been resolved.

Finally, some warning messages were encountered during the process. These have been addressed by modifying the relevant lines of code, ensuring results are now obtained without any warnings.

oberonia78 commented 6 months ago

@LiangJYu Thanks for the quick review on the PR