search

operasoftware / dns-ui

Opera's LDAP-authenticated PowerDNS user interface
Apache License 2.0
283 stars 57 forks source link

allow DNSSEC UI to be accessed read-only #153

Closed uedvt359 closed 4 years ago

uedvt359 commented 5 years ago

Finally, the last of the three pull requests. Again, we're happy to make any changes suggested in order to get our patches merged. Any feedback is welcome!

Notes

We are using PowerDNS and set DNSSEC manually on some zones, so we need to be able to see if a zone has it enabled or not. But having the big red and blue buttons is risky, as one might accidentally change DNSSEC settings, breaking stuff.

I've opted to overload the existing [dns]dnssec config option with a special value ro, but I'm happy to change that to a new pref as well. This way was chosen as it makes it backwards compatible and the patch very simple.

uedvt359 commented 4 years ago

I've rebased the patch on top of master again, so it'll apply cleanly. (after pr-datacolumns landed yesterday)

uedvt359 commented 4 years ago

@thomas-pike: Sorry for bothering, but could you please have another look at that (it should match your review now), and if merged tag a release for us? Thanks!

thomas-pike commented 4 years ago

Sorry for the delay. I've committed a refactored version of this patch. Can you take a look at #161 and see if it works for you?

uedvt359 commented 4 years ago

No worries about the delay ;-) #161 would work for us perfectly fine!

uedvt359 commented 4 years ago

closed in favour of #161