search

operasoftware / dns-ui

Opera's LDAP-authenticated PowerDNS user interface
Apache License 2.0
282 stars 57 forks source link

add "expand/collapse all" button to zone changelog #166

Closed uedvt359 closed 4 years ago

uedvt359 commented 4 years ago

This makes it possible to Ctrl-F search a zone's changelog.

Most of the changes are indentation, since it was necessary to move the show_changes() and related functions outside the $('table.changelog').each()-block.

show_changelog() was called with a second parameter, but it did not accept such one--I assume, a remnant of a previous version. I have removed the parameter from this call, and replaced it with a new optional one, which allows one to instead of toggling an entry, either show or hide it.

As usual, happy to change anything and thanks for your maintenance.

thomas-pike commented 4 years ago

Discovered one little bug after merging: expand all was not quite being selective enough once rows had already been expanded at least once. Fixed in 869b64f.