search

operasoftware / dns-ui

Opera's LDAP-authenticated PowerDNS user interface
Apache License 2.0
282 stars 57 forks source link

don't repeatedly update URL fragment with 'expand all' button #210

Closed uedvt359 closed 4 months ago

uedvt359 commented 4 months ago

in firefox, doing this more than 200 times causes the following error, and expansion stops after this many elements:

Too many calls to Location or History APIs within a short timeframe. Uncaught DOMException: The operation is insecure.

this limit was introduced in https://bugzilla.mozilla.org/show_bug.cgi?id=1314912

chrom{ium,e} doesn't implement this mitigation, but on large zones I managed to hang and subsequently crash the browser, instead.

thomas-pike commented 4 months ago

Nice catch. We indeed should not be updating the URL fragment at all when doing expand all.