operasoftware / dragonfly

Opera Dragonfly is a fully featured development and debugging tool integrated into the Opera browser.
http://www.opera.com/dragonfly/
Apache License 2.0
160 stars 48 forks source link

Fix DFL-3650 - need to escape control characters before parsing with innerHTML #107

Closed hzr closed 12 years ago

danfooo commented 12 years ago

Good!

hzr commented 12 years ago

Fixed the tooltip issue. The spans contains the control pictures as "fallback" (not that this will ever be needed).

hzr commented 12 years ago

And yes, this is totally ugly.

danfooo commented 12 years ago

Should those control pictures be used in escape_html too?

hzr commented 12 years ago

@danfooo I tried that, but that would require lots of changes to DOM editing. More than it's worth.

danfooo commented 12 years ago

Ah, I see. Seems like a good enough solution then.

p01 commented 12 years ago

Looks better.