operasoftware / dragonfly

Opera Dragonfly is a fully featured development and debugging tool integrated into the Opera browser.
http://www.opera.com/dragonfly/
Apache License 2.0
160 stars 48 forks source link

Task dfl 2491 resource inspector improvements #110

Closed p01 closed 12 years ago

hzr commented 12 years ago

Before I continue, it would be nice if the code could be cleaned up a bit to conform to the style guide. Most issues are camelcase, extra spaces (or no spaces) around operators or inside arguments list.

p01 commented 12 years ago

I can do a first pass of review fixes and code style cleanup. Any recommendation to style the nested Array Iteration methods call ?

hzr commented 12 years ago

You mean e.g.

  ctx.resourceList
  .forEach(function() {});

I'd do

  ctx.resourceList.forEach(function() {
    ...
  });

instead. If there are more, I'd do

  ctx.resourceList
    .forEach(function() {
    })
    .filter(function() {
    });
p01 commented 12 years ago

Yup. Thanks.

hzr commented 12 years ago

After fixing the outstanding issues, this is good to go IMO.

hzr commented 12 years ago

Latest commits look fine, just one question.

hzr commented 12 years ago

Looking fine.

danfooo commented 12 years ago

Checked the last 5 commits, seems fine. If it's all reviewed now it would be good to merge it.