search

operasoftware / operaprestodriver

OperaPrestoDriver is a vendor-supported WebDriver implementation that enables programmatic automation of Presto-based Opera products (i.e. v12 and older).
http://code.google.com/p/selenium/wiki/OperaDriver
Apache License 2.0
149 stars 65 forks source link

Support for proxy settings #81

Closed mexicano closed 12 years ago

mexicano commented 12 years ago

Hello!

I added a support for proxy settings https://github.com/operasoftware/operadriver/issues/68 Look at this, please, and merge if its good :)

And I have two questions:

  1. will this feature work correct if i will start OperaDriver via RemoteWebDriver?
DesiredCapabilities cap = DesiredCapabilities.opera();
cap.setCapability("opera.proxy", proxy);
WebDriver wd = new RemoteWebDriver(wdURL, cap);
  1. when i can see this feature in WebDriver release (may be approximately..) ?
andreastt commented 12 years ago

The format for the proxy settings over the DesiredCapabilities object should follow the Proxy JSON object design found here: https://code.google.com/p/selenium/wiki/DesiredCapabilities#Proxy_JSON_Object

The code for OperaSettings seems pretty good, though.

mexicano commented 12 years ago

Do you mean that we shouldn't use class org.openqa.selenium.Proxy ? it has all required properties.. and some additional :)

If you think it is better to add a new class that corresponds exactly to the format, then tell me please in which package should i add it?

Or maybe you mean that i must set ftp and ssl proxy prefs for "manual" proxyType too?

andreastt commented 12 years ago

So I made some changes to your patch and it's now on master: https://github.com/operasoftware/operadriver/compare/b393faaefa69...b31f586b7c48

Thank you!

Do you want to be credited in the AUTHORS file? If so, please send me your name and email address.