operasoftware / pdf.js

PDF Reader in JavaScript
Apache License 2.0
20 stars 4 forks source link

Who is maintaining the Opera extension? #7

Closed Rob--W closed 10 years ago

Rob--W commented 11 years ago

The PDF Viewer has received several updates and improvements, but the entry in the Add-on gallery is still over a month old.

Can you sync the addon with the latest version? If you're short on personnel to handle this, I volunteer to take this task, as I'm already the maintainer of the Chrome extension.

To update the extension, follow the following steps:

git remote add upstream https://github.com/mozilla/pdf.js.git
git checkout master
git merge upstream master
node make generic chrome
cd build/extensions/chrome
zip ../chrome.zip *
# Upload to addons.opera.com, await review and done!
# Update remote repository
git push origin master
5953lc commented 11 years ago

Is there any way to update the extension in the opera browser itself ? Opera is still stuck on the Version 0.8.169 from June 21, 2013. Obviously it's not a priority for opera, but it's a priority for me.

hennryns commented 11 years ago

Yes, the new Opera Extensions have very similar structure to Chrome Extension.

You can try to install and use this extension and download PDF Viewer Extension from Chrome Web Store.

Hopefully, @operasoftware would take the help from @Rob--W to maintain the Opera PDF Viewer Extension.

Thank you.

ghost commented 11 years ago

Hi guys,

the newest version of PDF Viewer extension is already available on addons portal: https://addons.opera.com/en/extensions/details/pdf-viewer/?display=en

It's based on latest pdf.js lib.

Rob--W commented 11 years ago

@ppodgorski There's a bug in the current version of the viewer, include this patch to allow users to view local PDF files: https://github.com/Rob--W/pdf.js/commit/a4dd4b17893be9c672721329fc4b9ff57ea0c1cc (the bug has gone unnoticed for a while, so local files are rarely viewed in Chrome. Regardless, it needs to be fixed)

I usually merge Chrome-specific bug fixes before they are merged with the master branch of PDF.js, you can see which commits are live in the Chrome extension at https://github.com/Rob--W/pdf.js/commits/cws-release.

ghost commented 11 years ago

@Rob--W Thank you for pointing this. We will include this code and release new version.

5953lc commented 11 years ago

I'd suggest closing this because it looks like Opera is looking at this and working with Rob.

Go Team!

:-)

When is the new version coming out Rob ?

hennryns commented 10 years ago

Dear @5953lc @ppodgorski

I still do not think if @operasoftware is already working with @Rob--W on this PDF.js extension.

The release of Opera PDF.js is still behind the release of Chrome PDF.js and Firefox PDF.js; @operasoftware has not updated this extension since weeks. This leaves the Opera users with less features and bug fixes of new release, and this is very annoying.

Again, I would like to suggest @operasoftware to take the help from @Rob--W to maintain the Opera PDF.js; so the Opera users can get the release update sooner.

Thank you.

ghost commented 10 years ago

Dear @hennryns,

thanks for making a valuable point on PDF Viewer extension. We are on it and working on updating our extension to latest version of pdf.js lib. Sorry for delay with updates but we are switching between tasks as fast as possible.

Best regards, Piotr

5953lc commented 10 years ago

Thanks Piotr

I noticed that Opera PDF viewrer and Rob's Chrome Extension are now at the save version, but they are radically different sizes Opera's 1.4M versus Chrome's 623KB.

What's hiding in Opera's extension ? A baby extension ?

By the way, PDF files generated via a form (POST request) CANNOT be viewed. Still!.... ONLY the GET method works.

Opera needs to get that chrome.streamsPrivate API into the Opera browser or the Opera pdf.js PDF Viewer addon,

Then the Opera/pdf viewer combo will work perfectly 100% of the time with any PDF/browser reception method GET or POST.

Lyle

ghost commented 10 years ago

Dear Lyle,

you're welcome :)

We are working hard to get more and more extensions API enabled in our browser. Please stay tune, we will have some new options soon :)

Best regards, Piotr

Rob--W commented 10 years ago

@5953lc Opera has inserted a 1MB PDF file in the extension, probably by accident or intentional as a demo. It's the same PDF file that's used by PDF.js to preview the PDF Viewer at http://mozilla.github.io/pdf.js/, namely http://cdn.mozilla.net/pdfjs/tracemonkey.pdf.

You can use the Chrome extension source viewer to see what's inside a Chrome or Opera extension with a single click (visit the options page to enable support for Opera extensions). I've only hosted it in the Chrome Web store, but if there's demand for it, I can also submit it to Opera's add-on gallery.

5953lc commented 10 years ago

Thanks for pointing that out. It was a bit disconcerting .... (And they still don't have the POST issue fixed ... or the streamsPrivate API ...)

(sigh)

Back to firefox/pdf.js combo until they do...

On Tue, Oct 1, 2013 at 12:41 PM, Rob Wu notifications@github.com wrote:

@5953lc https://github.com/5953lc Opera has inserted a 1MB PDF file in the extension, probably by accident or intentional as a demo. It's the same PDF file that's used by PDF.js to preview the PDF Viewer at http://mozilla.github.io/pdf.js/, namely http://cdn.mozilla.net/pdfjs/tracemonkey.pdf.

You can use the Chrome extension source viewerhttps://chrome.google.com/webstore/detail/chrome-extension-source-v/jifpbeccnghkjeaalbbjmodiffmgedinto see what's inside a Chrome or Opera extension with a single click (visit the options page to enable support for Opera extensions). I've only hosted it in the Chrome Web store, but if there's demand for it, I can also submit it to Opera's add-on gallery.

— Reply to this email directly or view it on GitHubhttps://github.com/operasoftware/pdf.js/issues/7#issuecomment-25481098 .

andreasbovens commented 10 years ago

@Rob--W I've filed https://github.com/operasoftware/pdf.js/issues/9 to fix the PDF file issue. Sorry about that.

As for the Chrome extension source viewer extension, can you submit it to the Opera extensions catalog? We'd be happy to feature it.

Rob--W commented 10 years ago

@andreasbovens Submitted as https://addons.opera.com/extensions/details/extension-source-viewer/.