search

operate-first / apps

Operate-first application manifests
GNU General Public License v3.0
51 stars 137 forks source link

Add Pep to ArgoCD admins #2671

Closed codificat closed 1 year ago

codificat commented 1 year ago

This PR is to add myself to the ArgoCD admins group. From time to time I keep finding that I can't access X or Y resource in ArgoCD, and this is an attempt at fixing that. Let me know if this is overkill.

Also taking the opportunity to remove Anand, who I believe is not active anymore.

codificat commented 1 year ago

Can you please let me know which projects you'd like to have access to and can't?

The trigger for the request was the ODH applications in OSC's cluster 1, which we use to contribute to the ODH custom notebook image functionality.

One example from earlier today: after https://github.com/operate-first/odh-manifests/pull/52 merged I was expecting the deployment of the dashboard in the aicoe-meteor namespace to get updated; this did not happen.

I ended up manually updating it in the cluster (I do have access to the cluster), but I can not even see the related resources in ArgoCD (https://github.com/operate-first/apps/tree/master/kfdefs/overlays/osc/osc-cl1).

I think we should adopt much broader read access - public read should become the default.

That would be nice :smiley:

Do you need to be able to perform manual changes to those apps?

Not really manual changes, as in theory these should all go via the apps repo... but eventually a manual sync might come handy. In the example below, the repos were up to date but the changes were not reflected in the cluster; not sure what was missing in the argocd side (as I can't see it) or what actions there might have been needed.

tumido commented 1 year ago

@codificat FFR: we're doing some policy changes around ArgoCD now (see @durandom's PR). I think all you want to achieve should be possible already without being an admin (without write access). If there are apps not synced, I think we should rather turn on autosync declaratively in the app manifest instead of manual interventions... That being said, I'm approving this PR.

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/apps/blob/master/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment