operate-first / apps

Operate-first application manifests
GNU General Public License v3.0
51 stars 137 forks source link

Added machinesets to osc cl1 to sync with cl2 #2699

Closed redmikhail closed 1 year ago

redmikhail commented 1 year ago

Part of the process of bringing osc-cl1 cluster to the level of control by operate-first processes as for ocs-cl2. Adding previously manually managed machinesets to the repo. Also adjustments to address https://github.com/os-climate/os_c_data_commons/issues/246

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from redmikhail by writing /assign @redmikhail in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[cluster-scope/overlays/prod/osc/OWNERS](https://github.com/operate-first/apps/blob/master/cluster-scope/overlays/prod/osc/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
redmikhail commented 1 year ago

/cc @MightyNerdEric @ryanaslett

redmikhail commented 1 year ago

@MightyNerdEric or @ryanaslett can you please review and provide lgtm and approval if everything correct

ryanaslett commented 1 year ago

The machinesets I checked seem to match exactly with whats defined in the cluster. I think the only questions I have are

  1. When we define something in kustomize that already exists in the cluster, with all of the same names and data, I assume kustomize figures out that its already there, and doesnt make any changes to the cluster itself? i..e do we run any risk of the cluster removing and rebuilding all of these machines if we do this?
  2. The (https://github.com/os-climate/os_c_data_commons/issues/246) is sort of confusing to me.. looks like everything is already defined as g4dn.2xlarge .. did anything change there?

Otherwise this all looks good to me.