search

operate-first / apps

Operate-first application manifests
GNU General Public License v3.0
51 stars 137 forks source link

fix: Increase kubeval job memory request to 4GB #2764

Closed mimotej closed 1 year ago

mimotej commented 1 year ago

As the bump to 1 GB in https://github.com/operate-first/apps/pull/2761 does not seem to be enough (as can be seen in https://github.com/operate-first/apps/pull/2759, which is still being OOMKilled) and from testing which I did it seems that kubeval can use more than 2 GB, I am bumping this value to 4GB to have some reserve.

Reason why this is happening is that kubeval caches in memory schemas which it might need for the validation. These schemas are regularly updated in schema-store and I suspect that lately there has been some change that impacted size of the schemas dramatically. This means that also size that is cached increased.

mimotej commented 1 year ago

/cc @tumido

goern commented 1 year ago

/lgtm /approve

goern commented 1 year ago

/assign @tumido

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/apps/blob/master/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment