operate-first / apps

Operate-first application manifests
GNU General Public License v3.0
51 stars 137 forks source link

feat: Add MachineWithoutValidNode alert #2765

Closed mimotej closed 1 year ago

mimotej commented 1 year ago

This PR adds a MachineWithoutValidNode alert. The metrics it uses do not include managed_cluster_id label by default but they have clusterID instead. In this case clusterID is the ID of the cluster the alert originated in (therefore we can define managed_cluster_id label ourselves). For now I used following guide If you have ideas for better guide feel free to point them out.

mimotej commented 1 year ago

/cc @tumido

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/apps/blob/master/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mimotej commented 1 year ago

/retest