search

operate-first / apps

Operate-first application manifests
GNU General Public License v3.0
51 stars 137 forks source link

fix: Add by clause to PromQL expression custom rule #2769

Closed mimotej closed 1 year ago

mimotej commented 1 year ago

The custom alert rule MachineWithoutValidNode does not seem to display proper labels. The PromQL expression is missing aggregation operator which would add proper labels to the alert. More about aggregation can be seen here Here is the result of query without aggregation image Here is the result of query with aggregation image

mimotej commented 1 year ago

/cc @tumido

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/apps/blob/master/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment