search

operate-first / apps

Operate-first application manifests
GNU General Public License v3.0
51 stars 137 forks source link

feat(tekton): Add new pipeline resource permissions for tekton plugin #2791

Closed debsmita1 closed 1 year ago

debsmita1 commented 1 year ago

pipelinerun and taskrun resource permissions are required for fetching these resources in the Tekton plugin

/cc @tumido

sesheta commented 1 year ago

Hi @debsmita1. Thanks for your PR.

I'm waiting for a operate-first member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/apps/blob/master/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tumido commented 1 year ago

/retest

tumido commented 1 year ago

/override kubeval-validation /override kustomize-build /override pre-commit

verified manually

tumido commented 1 year ago

/ok-to-test

sesheta commented 1 year ago

@tumido: Overrode contexts on behalf of tumido: aicoe-ci/prow/kubeval-validation, aicoe-ci/prow/kustomize-build, aicoe-ci/prow/pre-commit

In response to [this](https://github.com/operate-first/apps/pull/2791#issuecomment-1536156342): >/override kubeval-validation >/override kustomize-build >/override pre-commit > >verified manually Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sesheta commented 1 year ago

@debsmita1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit f5ce0297a6bbcf47c1eb656d5c43f7166e6f9287 link true /test pre-commit
aicoe-ci/prow/kubeval-validation f5ce0297a6bbcf47c1eb656d5c43f7166e6f9287 link true /test kubeval-validation
aicoe-ci/prow/kustomize-build f5ce0297a6bbcf47c1eb656d5c43f7166e6f9287 link true /test kustomize-build

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).