search

operate-first / apps

Operate-first application manifests
GNU General Public License v3.0
51 stars 137 forks source link

⚡ removing the workshop related stuff #clarety #2794

Closed goern closed 1 year ago

goern commented 1 year ago

Signed-off-by: Christoph Görn goern@b4mad.net

goern commented 1 year ago

pre-commit warning arise from wrong comment indention

/cc @Gregory-Pereira

durandom commented 1 year ago

Why would we want to remove this? Isn't this a good starting point for hosting workshops on a cluster?

goern commented 1 year ago

ja it is, I just wanted to declutter this repo, as it feels a little complex. and touching 85 files to deploy a workshop environment appeared strange to me.

Gregory-Pereira commented 1 year ago

/override aicoe-ci/prow/pre-commit /lgtm /approve

op1st-prow[bot] commented 1 year ago

@Gregory-Pereira: Overrode contexts on behalf of Gregory-Pereira: aicoe-ci/prow/pre-commit

In response to [this](https://github.com/operate-first/apps/pull/2794#issuecomment-1548022794): >/override aicoe-ci/prow/pre-commit >/lgtm >/approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
op1st-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gregory-Pereira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/apps/blob/master/OWNERS)~~ [Gregory-Pereira] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment