search

operate-first / blueprint

This is the blueprint for the Operate First Initiative
GNU General Public License v3.0
16 stars 16 forks source link

Improvements to the blueprints readme #100

Closed margarethaley closed 3 years ago

margarethaley commented 3 years ago

Made some changes to the blueprints readme page

Resolves https://github.com/operate-first/operate-first.github.io/issues/259

hemajv commented 3 years ago

lgtm! :ship:

oindrillac commented 3 years ago

Is the pre-commit fail issue here related to the ongoing issues with prow https://github.com/operate-first/SRE/issues/347? cc: @harshad16 @HumairAK

HumairAK commented 3 years ago

/retest

HumairAK commented 3 years ago

@oindrillac probably, let's merge this for now, I ran the pre-commit locally, it ran fine

HumairAK commented 3 years ago

/approve

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/blueprint/blob/main/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 3 years ago

@margarethaley: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
aicoe-ci/prow/pre-commit 93770244c984aaa260cb36319aaae438c514e935 link /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).