operate-first / common

Git Hub organization configuration
GNU General Public License v3.0
6 stars 64 forks source link

add jbrooks #106

Closed jasonbrooks closed 2 years ago

sesheta commented 2 years ago

Hi @jasonbrooks. Thanks for your PR.

I'm waiting for a operate-first member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
HumairAK commented 2 years ago

/ok-to-test /override peribolos

sesheta commented 2 years ago

@HumairAK: /override requires a failed status context or a job name to operate on. The following unknown contexts were given:

Only the following contexts were expected:

In response to [this](https://github.com/operate-first/common/pull/106#issuecomment-1119043189): >/ok-to-test >/override peribolos Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
HumairAK commented 2 years ago

apologies, looks like this went under the radar

/retest /override peribolos

sesheta commented 2 years ago

@HumairAK: Overrode contexts on behalf of HumairAK: community-management/prow/peribolos

In response to [this](https://github.com/operate-first/common/pull/106#issuecomment-1138602583): >apologies, looks like this went under the radar > >/retest >/override peribolos Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
HumairAK commented 2 years ago

/override peribolos

sesheta commented 2 years ago

@tumido: Failed to get presubmits

In response to [this](https://github.com/operate-first/common/pull/106#pullrequestreview-998396680): >/override community-management/prow/peribolos >/lgtm >/approve >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/common/blob/main/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tumido commented 2 years ago

/unhold

jasonbrooks commented 2 years ago

This has been a journey! Let me know if I did something wrong, or if there's something I need to fix. :)

HumairAK commented 2 years ago

@jasonbrooks for context there is an ongoing issue with our peribolos configurations, I believe @tumido is using this pr as a test case while he tries to fix the issues.

tumido commented 2 years ago

Hey, sorry for the mess, I had to cleanup some of the broken config that got merged in before for some reason. I hope it will be working already just to merge yours and then I've noticed some more broken stuff. :smile: :smirk: I've also modified your PR to list your GH handle instead of jbrooks - that wouldn't work. :slightly_smiling_face: I'll continue investigating the issue and eventually merge this in. Sorry again.

tumido commented 2 years ago

/test all