Forgot to create maintainers for the blog

operate-first / common

Git Hub organization configuration

GNU General Public License v3.0

6 stars 64 forks source link

Forgot to create maintainers for the blog #112

Closed quaid closed 2 years ago

quaid commented 2 years ago

This should fill out the roles properly now
Note the cascading roles, hoping someone else can confirm I have the cascade correct blog members can write and review (triage the repo) blog-editorial members can review and publish (write in the repo) blog-publishers members can rework the publishing platform ... but what is the difference between maintainers and members and do I have it configured correctly?
- e.g. should maintainers also be in the members list?

Signed-off-by: Karsten Wade kwade@redhat.com

schwesig commented 2 years ago

/lgtm

HumairAK commented 2 years ago

/lgtm /approve /override peribolos

sesheta commented 2 years ago

@HumairAK: Overrode contexts on behalf of HumairAK: community-management/prow/peribolos

In response to [this](https://github.com/operate-first/common/pull/112#issuecomment-1142246822): >/lgtm >/approve >/override peribolos Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/common/blob/main/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

quaid commented 2 years ago

@schwesig @HumairAK I still don't have write permissions to the repo, which I thought this PR would do?!?

schwesig commented 2 years ago

@schwesig @HumairAK I still don't have write permissions to the repo, which I thought this PR would do?!?

I thought so too. I checked where my github user is listed, and we are mostly in the the groups. @HumairAK any ideas, what I oversee?

HumairAK commented 2 years ago

guessing this is related to: https://github.com/operate-first/common/issues/101 will add it to back log to investigate

Gregory-Pereira commented 2 years ago

@quaid can you confirm if you still don't have write permissions, I am testing to see if #101 is still active.

quaid commented 2 years ago

@quaid can you confirm if you still don't have write permissions, I am testing to see if #101 is still active.

Confirming, the test is if I have write permissions to the website (which now houses the blog)?

I do have write/merge permissions for that repo. When this was opened, it was about not having write permissions to the blog repo, so I don't know the what ended up resolving my blocker but I am no longer blocked.