search

operate-first / common

Git Hub organization configuration
GNU General Public License v3.0
6 stars 64 forks source link

Add Dylan to the operate-first org #33

Closed dystewart closed 3 years ago

dystewart commented 3 years ago

This request is to add me to the github org.

sesheta commented 3 years ago

Hi @dystewart. Thanks for your PR.

I'm waiting for a operate-first member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
HumairAK commented 3 years ago

Hey @dystewart thanks! Can you squash your commits down to one? See the third point here for more details on the reasoning behind squashing.

HumairAK commented 3 years ago

@dystewart I see that you are adding a commit that already exists: this vs this

I think you may have squashed this commit with another commit and that's why now it's showing 2 authors. I'd suggest just going into interactive rebase and removing this commit.

dystewart commented 3 years ago

@HumairAK removed the previous commit

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/common/blob/main/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 3 years ago

@dystewart: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
aicoe-ci/prow/pre-commit 4404a5df2f1a1ebf09eb1276b2c6440ea25de943 link /test pre-commit
community-management/prow/peribolos 4404a5df2f1a1ebf09eb1276b2c6440ea25de943 link /test peribolos

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).