search

operate-first / common

Git Hub organization configuration
GNU General Public License v3.0
6 stars 64 forks source link

Add 'sre' team with admin on 'slo-evaluator' repo #61

Closed mmazur closed 2 years ago

mmazur commented 2 years ago

New team will create and maintain various SRE–related materials. It will not be performing SRE activities, as there's already a SIG Ops which has the responsibility of dealing with ops tasks on the op1st cloud.

The initial slo-evaluator repo is a python project for an engine evaluating and storing SLOs (code is here for the time being.).

sesheta commented 2 years ago

Hi @mmazur. Thanks for your PR.

I'm waiting for a operate-first member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
HumairAK commented 2 years ago

/lgtm

mmazur commented 2 years ago

/test peribolos

sesheta commented 2 years ago

@mmazur: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/operate-first/common/pull/61#issuecomment-1032659972): >/test peribolos Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mmazur commented 2 years ago

/retest-required

sesheta commented 2 years ago

@mmazur: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/operate-first/common/pull/61#issuecomment-1032660985): >/retest-required Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mmazur commented 2 years ago

I've tried looking into the failed CI job, but I don't really understand why it's failing and am unable to make it try again.

HumairAK commented 2 years ago

@mmazur yes we just found out there is an issue with the ci here, we suspect: https://github.com/operate-first/common/issues/63

For now can you rebase and I'll go ahead and manually merge it

mmazur commented 2 years ago

Rebased.

durandom commented 2 years ago

/approve

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: durandom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/common/blob/main/OWNERS)~~ [durandom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
durandom commented 2 years ago

/lgtm

mmazur commented 2 years ago

Ci still failing. 😕

HumairAK commented 2 years ago

/override community-management/prow/peribolos

sesheta commented 2 years ago

@HumairAK: Overrode contexts on behalf of HumairAK: community-management/prow/peribolos

In response to [this](https://github.com/operate-first/common/pull/61#issuecomment-1033828523): >/override community-management/prow/peribolos Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.