search

operate-first / community

GNU General Public License v3.0
11 stars 6 forks source link

Updates with answers to questions received #252

Closed quaid closed 1 year ago

quaid commented 1 year ago
sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cooktheryan Once this PR has been reviewed and has the lgtm label, please ask for approval from quaid by writing /assign @quaid in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/operate-first/community/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 1 year ago

@quaid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit 4e66fb345fa9b69bc0a95bf774d8bf10812924c0 link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jasonbrooks commented 1 year ago

@quaid This looks good. I wonder if it'd be helpful if the "what is NERC" bit was moved up higher.