search

operate-first / hitchhikers-guide

Hitchhiker's guide to Operate-first
GNU General Public License v3.0
3 stars 8 forks source link

feat: Update cluster onboarding guide to support monitoring and better logical flow #103

Closed tumido closed 3 years ago

tumido commented 3 years ago

Resolves: https://github.com/operate-first/hitchhikers-guide/issues/84 Follow up to #15

This PR changes the flow of the guide to:

  1. Setup all variables
  2. Clone apps repo
  3. Enable ArgoCD in ACM
  4. Enable SSO
  5. Create cluster admin group since we have SSO and users
  6. Create cluster scope overlay
  7. Enable monitoring
  8. Create ArgoCD apps for all above
  9. Commit

Example PR created by executing the notebook https://github.com/tumido/apps/commit/e4157cfe670122b43e2a7cc0c8fd44eded3a1eca

tumido commented 3 years ago

/cc @HumairAK @4n4nd @mimotej

mimotej commented 3 years ago

Looks good thank you for changes :+1: /lgtm

tumido commented 3 years ago

Updated to decouple DNS_LOCATION and CLUSTER_REGION. This is the result https://github.com/tumido/apps/commit/9252d2d73e98c6c2aaa5102b000b96892484788e

HumairAK commented 3 years ago

/lgtm /approve

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, mimotej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/hitchhikers-guide/blob/main/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment