operate-first / hitchhikers-guide

Hitchhiker's guide to Operate-first
GNU General Public License v3.0
3 stars 8 forks source link

Correct inconsistencies in notebook for proj onboarding. #117

Closed HumairAK closed 2 years ago

HumairAK commented 2 years ago

As per: https://github.com/operate-first/SRE/issues/417#issuecomment-981802687

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from humairak after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/operate-first/hitchhikers-guide/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 2 years ago

@HumairAK: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit a122457bfcca1f0ec782d79f38888b87a22d9ec4 link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
4n4nd commented 2 years ago

/lgtm

schwesig commented 2 years ago

/lgtm

Gregory-Pereira commented 2 years ago

/Igtm