search

operate-first / hitchhikers-guide

Hitchhiker's guide to Operate-first
GNU General Public License v3.0
3 stars 8 forks source link

update aicoe-ci config to build container image using repo containerfile #121

Closed 4n4nd closed 2 years ago

4n4nd commented 2 years ago

Resolves https://github.com/operate-first/hitchhikers-guide/issues/120

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign humairak after the PR has been reviewed. You can assign the PR to them by writing /assign @humairak in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/operate-first/hitchhikers-guide/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harshad16 commented 2 years ago

/retest

mimotej commented 2 years ago

/lgtm I think the Containerfile should be fine to use :+1:

4n4nd commented 2 years ago

/hold

4n4nd commented 2 years ago

I think the Containerfile is building a base image that we could use to build tha hitchhiker's guide image. @tumido is that the case here?

sesheta commented 2 years ago

New changes are detected. LGTM label has been removed.

4n4nd commented 2 years ago

Looks like we don't need this PR anymore, the builder image is directly being built in quay and the htg image should build