search

operate-first / operate-first-data-science-community

GitHub home of operate first data science community content
https://operate-first-data-science-community.catalog.meteor.zone/
GNU General Public License v3.0
8 stars 12 forks source link

adding pre-commit and google analytics #123

Closed schwesig closed 2 years ago

schwesig commented 2 years ago

pre-commit rules taken from https://github.com/AICoE/elyra-aidevsecops-tutorial/blob/master/.pre-commit-config.yaml

schwesig commented 2 years ago

/assign @schwesig /cc @codificat /cc @aakankshaduggal

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aakankshaduggal, codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/operate-first-data-science-community/blob/main/OWNERS)~~ [aakankshaduggal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codificat commented 2 years ago

if you would like CI to run the precommit check on pr then include this file in this repo as well https://github.com/AICoE/elyra-aidevsecops-tutorial/blob/0ff073756d4b6b1f7b787cb01ce42b7c3c7859c8/.prow.yaml#L2

@schwesig do you want to include that file in the PR so that pre-commit is checked on new PRs moving forward?

schwesig commented 2 years ago

if you would like CI to run the precommit check on pr then include this file in this repo as well AICoE/elyra-aidevsecops-tutorial@0ff0737/.prow.yaml#L2

@schwesig do you want to include that file in the PR so that pre-commit is checked on new PRs moving forward?

yes, we just did. thanks @harshad16 for reminding me

codificat commented 2 years ago

Thanks! /lgtm