search

operate-first / operate-first.github.io-old

GNU General Public License v3.0
18 stars 42 forks source link

detect bad HTML to prevent notebook renderer from failing #268

Closed oindrillac closed 3 years ago

oindrillac commented 3 years ago

We faced an issue (#267) with the line breaks in external notebooks which are added to the site to be detected as bad HTML which cause our notebook renderer to error out resulting in a build fail. We need to include a plugin which automatically detects occurrences of bbad HTML.

Gage Krumbach wrote: in the long run there should probably be some plugin that detects bad HTML. I saw that the newer version of the notebook renderer recommended to use one. Especially if the notebooks are being pulled from external sources

cc: @Gkrumbach07

Gkrumbach07 commented 3 years ago

This is the bad HTML fix

This plugin can be used on top of the markdown renderer. Could be hard to implement however due to the package not having this capability inherently at the current version we are using. Would have to do some testing to see whats possible.

sesheta commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

tumido commented 3 years ago

Should be resolved by #312 and #313 since each PR is attempted to be built also with better logging about which page is being processed - minimizing the failure chance on merge.