Closed oindrillac closed 3 years ago
cc: @tumido
Oindrilla Chatterjee wrote: Some react packages seem to be causing the website build fail. https://github.com/operate-first/operate-first.github.io/issues/303 Anybody familiar with react who can help? We would need some changes to reflect on the website for our upcoming devconf talks.
Gage Krumbach wrote: it looks like it could be the same error as before with the
hr
tag.error message was "
hr is a void element tag and must neither have
childrennor use
dangerouslySetInnerHTML.
"Oindrilla Chatterjee wrote: Gage Krumbach is there a way to tell which notebook is causing this issue?
Gage Krumbach wrote: im looking into that now. shouldn't be to difficult to find
Oindrilla Chatterjee wrote: thank you!
Gage Krumbach wrote: think it might be this notebook: https://github.com/aicoe-aiops/ocp-ci-analysis/blob/master/notebooks/time-to-merge-prediction/model_inference.ipynb
Oindrilla Chatterjee wrote: I see
Gage Krumbach wrote: i ran it again without the notebook at it didnt throw an error. i remember last time the error was thrown because of some headers in the notebook
Oindrilla Chatterjee wrote: right. I see the line breaks in the notebook
Oindrilla Chatterjee wrote: i will remove it
Oindrilla Chatterjee wrote: it seems like even 3 hyphens seem to be rejected by it
Gage Krumbach wrote: we want to use something like this https://github.com/rehypejs/rehype-sanitize to clean up the markdown portions of the notebooks. currently the notebook-renderer we use doesnt do that. https://github.com/rafaelquintanilha/notebook-render/blob/master/src/index.tsx#L177.
Gage Krumbach wrote: all it does is remove those bad portions so everything still runs fine
Oindrilla Chatterjee wrote: fixed the notebook here https://github.com/aicoe-aiops/ocp-ci-analysis/pull/370 and re-triggered a build, hoping that works!
_Transcript of Slack thread: https://operatefirst.slack.com/archives/C01RMPVUUK1/p1630519513063800?thread_ts=1630519513.063800&cid=C01RMPVUUK1_
The last 3 builds of the website failed. The last build which ran successfully was from https://github.com/operate-first/operate-first.github.io/pull/290