search

operate-first / service-catalog

Service catalog for the operate-first community cloud
GNU General Public License v3.0
8 stars 6 forks source link

chore: Bump backstage to 1.8.2 #192

Closed SamoKopecky closed 2 years ago

SamoKopecky commented 2 years ago

Release notes: https://github.com/backstage/backstage/releases/tag/v1.8.0 Upgrade helper: https://backstage.github.io/upgrade-helper/?from=1.7.0&to=1.8.2

Changes

tumido commented 2 years ago

/hold

We can't do this as of now. We don't have an UBI based nodejs v18 image available without auth yet. https://bugzilla.redhat.com/show_bug.cgi?id=2143885

SamoKopecky commented 2 years ago

/hold

We can't do this as of now. We don't have an UBI based nodejs v18 image available without auth yet. bugzilla.redhat.com/show_bug.cgi?id=2143885

I think we can still use the nodejs v16 version since its still supported by backstage. We can switch to v18 later when it becomes available without auth. When I tried build and run it with v16 image it still worked fine.

tumido commented 2 years ago

Oh.. I didn't read the PR properly, you're not locking to v18 yet.... in that case we can proceed with this. The BZ was just resolved anyways so I'll work on updating node to v18 via separate PR.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/service-catalog/blob/main/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment