operate-first / service-catalog

Service catalog for the operate-first community cloud
GNU General Public License v3.0
8 stars 6 forks source link

fix: Fix size of terminal not being same on xterm and pod #207

Closed mimotej closed 1 year ago

mimotej commented 1 year ago

Fixes problem with xterm.js terminal not being the same size as expected size of the window by terminal running in pod. This would mean that terminal would have either large paddings or the text would get rewrited since the sizes of terminals would not be same.

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/service-catalog/blob/main/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment