search

operate-first / service-catalog

Service catalog for the operate-first community cloud
GNU General Public License v3.0
8 stars 6 forks source link

feat: Use cluster annotation instead of form field #210

Closed mimotej closed 1 year ago

mimotej commented 1 year ago

Uses new annotation in resource kubernetes.io/api-server instead of having to input a cluster API server manually Related to: https://github.com/janus-idp/backstage-plugins/pull/94 Part of: https://github.com/janus-idp/backstage-plugins/issues/81

mimotej commented 1 year ago

/hold let's hold this until https://github.com/janus-idp/backstage-plugins/pull/94 is merged and we can verify that there is no issue with this setup

mimotej commented 1 year ago

@tumido Had to rebase commits so that the fixes in https://github.com/operate-first/service-catalog/pull/211 are applied

mimotej commented 1 year ago

/unhold https://github.com/operate-first/service-catalog/pull/211 applies changes made in https://github.com/janus-idp/backstage-plugins/pull/94 and everything seems to work fine

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/service-catalog/blob/main/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment