operate-first / service-catalog

Service catalog for the operate-first community cloud
GNU General Public License v3.0
8 stars 6 forks source link

feat: Enable changing of namespace in UI #214

Closed mimotej closed 1 year ago

mimotej commented 1 year ago

This PR adds a dropdown menu with all the namespaces in the cluster where user can choose proper namespace to start a pod in. This dropdown menu only displays if the request in default namespace (openshift-terminal). Chosen namespace is then used to initialize environment and is sent to the webterminal-proxy. Example of form before first request: image When the request fails image *User must be able to read namespaces otherwise the list will be empty Part of: https://github.com/operate-first/service-catalog/issues/213

Edit added functionality to input default namespace which will be used this configuration is optional and if not specified it uses openshift-terminal Example of usage:

webTerminal:
  webSocketUrl: "ws://localhost:8080/"
  defaultNamespace: "namespace"

Edit 2 Updated version now displays a modal instead of inlining select image

Resolves https://github.com/operate-first/service-catalog/issues/213

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/service-catalog/blob/main/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment