search

operate-first / service-catalog

Service catalog for the operate-first community cloud
GNU General Public License v3.0
8 stars 6 forks source link

fix: Fix originLocation.type check and prometheus.io/alert annotation #219

Closed mimotej closed 1 year ago

mimotej commented 1 year ago

This PR fixes issue with annotations not being properly added to entity in preprocessing. Before fix: image After fix: image

Also fixes in the second commit typo in prometheus.io/alert :no_mouth:

mimotej commented 1 year ago

/cc @tumido

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operate-first/service-catalog/blob/main/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment