search

operate-first / support

This repo should serve as a central source for users to raise issues/questions/requests for Operate First.
GNU General Public License v3.0
15 stars 25 forks source link

Do we have a section describing how to update grafana dashboard once a new version of the JSON template is modified #574

Closed pacospace closed 1 year ago

pacospace commented 2 years ago

Describe the process on how to get a new version of the grafana dashboard updated:

  1. Modify your grafana dashboards, making sure the ID is different
  2. Modify the grafana operator CRD, changing version, so that the operator recognizes the change in the CRD
  3. ??
HumairAK commented 2 years ago

Not sure I understand.

Assuming you are talking about: https://grafana.operate-first.cloud/?orgId=1

Add your new dashboard per instructions here: https://www.operate-first.cloud/apps/content/grafana/add_grafana_dashboard.html

IIRC once merged by argocd, grafana ends up re-deploying with the new dashboard. I don't think the id needs to be different.

@4n4nd might know more.

pacospace commented 2 years ago

Not sure I understand.

Assuming you are talking about: https://grafana.operate-first.cloud/?orgId=1

Add your new dashboard per instructions here: https://www.operate-first.cloud/apps/content/grafana/add_grafana_dashboard.html

IIRC once merged by argocd, grafana ends up re-deploying with the new dashboard. I don't think the id needs to be different.

@4n4nd might know more.

I remember there was an issue in grafana operator upstream, because ArgoCD, when not changing the CRD but changing the JSON content without the link in the CRD, does not retrigger a sync to my knowledge as the CRD is still the same. But maybe the feature @4n4nd introduced fixed that.

Reference: https://github.com/thoth-station/thoth-application/issues/1004 and @4n4nd issue upstream: https://github.com/grafana-operator/grafana-operator/issues/440#issue-929322851

so my question or feature is if we expect to write some docs about this, when a user is using operate first grafana operator and the user is updating their JSON dashboard, what steps do they have to take to make sure their new JSON is redeployed. The last time I remember the CRD would have to be updated with a different version.

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

durandom commented 2 years ago

Probably a question for services catalog? If we consider grafana to be a service @4n4nd

quaid commented 2 years ago

@pacospace @4n4nd this seems like an open questions still, yes?

/remove-lifecycle stale

sesheta commented 2 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta commented 2 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 1 year ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 1 year ago

@sesheta: Closing this issue.

In response to [this](https://github.com/operate-first/support/issues/574#issuecomment-1356869093): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.