`proc_http`, `lib_http` improvements

[vcavallo]

Items that fell out of http cleanup (https://github.com/operating-function/pallas/pull/21) and needed a place go to be addressed in a separate chunk of work.

• [ ] parseAndSetBody : add test for body longer than Content-Length header indicated

• [ ] validRequest : actually do check here

• [ ] validResponse : actually do check here

• [ ] appResponseToHTTP:

  • [ ] response validity:

    TODO: check validity of headers/body/code we got from app here
    ; Formulate an HTTPResponse anyway (probably a 500 or whatever)
    | ifNot (validResponse b#{TODO})

  • [ ] reason phrase from app

    ; TODO:
    ; - reason phrase should come from app but be overridable by server in case error
    ; [...]
    @ reasonPhrase | reason

  • [ ] add date header

    ; TODO: need
    ; @ headers | tabIns b#{Date}

  • [ ] add additional headers?

    ; TODO: others, maybe:
    ; @ headers | tabIns b#{Content-Encoding}
    ; @ headers | tabIns b#{Content-Type}

  • [ ] header list concat/colon feels wrong here

    ; This concatenation with colons _could_ be done in a subsequent function that
    ; is responsible for HTTP_RES -> Hex Bar
    @ headersList
    | tabValsList
    | tabMapWithKey
    (k v & (barCat [k b#{: } v]))
    headers

• [ ] more coming soon

[vcavallo]

May be useful later

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;
; Unused for now - potentially useful later.
;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

> Bar > Word32
= (ipToWord ipBar)
@ octets (listToRow | barSplit 46 ipBar) ; 46 is ASCII for '.'
| if (neq 4 | len octets)
  | die {Invalid IP address format}
^ foldl _ 0 octets
& (acc octet)
@ value (barLoadDecimal octet)
| if (or (lth value 0) (gth value 255))
  | die {Invalid octet value}
| add (lsh acc 8) value

> Word32 > Bar
= (wordToIp ipWord)
@ octet1 | barShowDecimal (div ipWord 16777216)
@ octet2 | barShowDecimal (mod (div ipWord 65536) 256)
@ octet3 | barShowDecimal (mod (div ipWord 256) 256)
@ octet4 | barShowDecimal (mod ipWord 256)
| barCat [octet1 b#{.} octet2 b#{.} octet3 b#{.} octet4]

= testIp b#{192.168.1.2}
= testWord (ipToWord testIp)
= backToIp (wordToIp testWord)

=?= testIp backToIp

= testIp b#{192.0.0.0}
= testWord (ipToWord testIp)
= backToIp (wordToIp testWord)

=?= testIp backToIp