search

operator-framework / catalogd

On-cluster FBC catalog content server
Apache License 2.0
14 stars 31 forks source link

:bug: check the underlying storage for existing cluster catalog content #290

Closed itroyano closed 3 months ago

itroyano commented 3 months ago

Fixes #288

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.53%. Comparing base (7615cf4) to head (70d91c0). Report is 2 commits behind head on main.

Files Patch % Lines
pkg/controllers/core/clustercatalog_controller.go 71.42% 1 Missing and 1 partial :warning:
pkg/storage/localdir.go 71.42% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #290 +/- ## ========================================== + Coverage 33.12% 33.53% +0.40% ========================================== Files 15 15 Lines 646 656 +10 ========================================== + Hits 214 220 +6 - Misses 411 413 +2 - Partials 21 23 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joelanford commented 3 months ago

@everettraven, an aside: I see a failure in go-apidiff. I wouldn't expect this code to be in our public API. In preparation for a v1.0, should we take a moment to make sure that the only code in our public API are the catalogd types?

everettraven commented 3 months ago

@everettraven, an aside: I see a failure in go-apidiff. I wouldn't expect this code to be in our public API. In preparation for a v1.0, should we take a moment to make sure that the only code in our public API are the catalogd types?

@joelanford i think that is reasonable. I imagine that should fall under the v1.0 epic to evaluate catalogd's public API surface?