search

operator-framework / deppy

Deppy: The dependency resolver for Kubernetes
Apache License 2.0
14 stars 21 forks source link

⚠️ Remove `DeppySolver` wrapper and export internal solver instead #165

Closed m1kola closed 5 months ago

m1kola commented 5 months ago

Closes #161

codecov[bot] commented 5 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (e676cce) 63.90% compared to head (4dfd241) 63.36%. Report is 1 commits behind head on main.

:exclamation: Current head 4dfd241 differs from pull request most recent head eae1c32. Consider uploading reports for the commit eae1c32 to get more accurate results

Files Patch % Lines
cmd/dimacs/cmd.go 0.00% 9 Missing :warning:
pkg/deppy/solver/solve.go 89.28% 4 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #165 +/- ## ========================================== - Coverage 63.90% 63.36% -0.54% ========================================== Files 11 10 -1 Lines 482 464 -18 ========================================== - Hits 308 294 -14 + Misses 155 154 -1 + Partials 19 16 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ncdc commented 5 months ago

LGTM once you rebase!

m1kola commented 5 months ago

@ncdc rebased. Please take another look.