search

operator-framework / deppy

Deppy: The dependency resolver for Kubernetes
Apache License 2.0
14 stars 21 forks source link

⚠️ Remove getter methods from constraints #166

Closed m1kola closed 5 months ago

m1kola commented 5 months ago

We export fields from constraints instead

Closes #154

codecov[bot] commented 5 months ago

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (75c37b5) 63.36% compared to head (682ee65) 63.77%.

Files Patch % Lines
pkg/deppy/constraint/constraint.go 0.00% 23 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #166 +/- ## ========================================== + Coverage 63.36% 63.77% +0.41% ========================================== Files 10 10 Lines 464 461 -3 ========================================== Hits 294 294 + Misses 154 151 -3 Partials 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ncdc commented 5 months ago

LGTM when ready!

m1kola commented 5 months ago

@ncdc rebased on top of main (no conflicts) and marked as ready. Please take another look.