search

operator-framework / helm-operator-plugins

Experimental refactoring of the operator-framework's helm operator
Apache License 2.0
48 stars 48 forks source link

bump go 1.22 and k8s 1.30 #337

Closed everettraven closed 3 months ago

everettraven commented 3 months ago

/hold

everettraven commented 3 months ago

/hold cancel

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 75.51020% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 48.35%. Comparing base (08ab7fb) to head (6f03f8b). Report is 19 commits behind head on main.

Files Patch % Lines
pkg/internal/predicate/predicates.go 18.18% 8 Missing and 1 partial :warning:
pkg/reconciler/internal/hook/hook.go 89.47% 0 Missing and 2 partials :warning:
internal/flags/flag.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #337 +/- ## =========================================== - Coverage 85.06% 48.35% -36.72% =========================================== Files 19 62 +43 Lines 1346 2914 +1568 =========================================== + Hits 1145 1409 +264 - Misses 125 1423 +1298 - Partials 76 82 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rashmigottipati commented 3 months ago

Do we need to bump the go version for the testdata as well?

everettraven commented 3 months ago

Do we need to bump the go version for the testdata as well?

I think to properly bump this - yes. I think this means we have to wait for Kubebuilder to bump the support in their Go plugin, cut a release, and pull that in. I'm not sure we should block on that though since for the OLMv1 repositories we don't need any of the Kubebuilder based stuff.

I will consult with @varshaprasad96 and @joelanford tomorrow morning to get their thoughts

everettraven commented 3 months ago

@rashmigottipati I realized that the generated testdata is of the hybrid plugin and we control the versions there. Should be updated as of https://github.com/operator-framework/helm-operator-plugins/pull/337/commits/a09a349baf542798185d577bdfa96cbae0b253e7