operator-framework / helm-operator-plugins

Experimental refactoring of the operator-framework's helm operator
Apache License 2.0
49 stars 49 forks source link

Bump Kubebuilder to v4 #346

Closed Neo2308 closed 1 month ago

Neo2308 commented 4 months ago

Summary of all breaking changes in Kubebuilder v3->v4 can be found at https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v4.0.0

Relates to https://github.com/operator-framework/operator-sdk/issues/6730

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.01%. Comparing base (08ab7fb) to head (06c06d5). Report is 35 commits behind head on main.

Files Patch % Lines
pkg/plugins/util/helpers.go 50.00% 2 Missing :warning:
pkg/plugins/helm/v1/api.go 0.00% 1 Missing :warning:
pkg/plugins/helm/v1/init.go 0.00% 1 Missing :warning:
pkg/plugins/hybrid/v1alpha/init.go 0.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (06c06d5). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (08ab7fb) | HEAD (06c06d5) | |------|------|------| ||2|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #346 +/- ## =========================================== - Coverage 85.06% 52.01% -33.06% =========================================== Files 19 66 +47 Lines 1346 3232 +1886 =========================================== + Hits 1145 1681 +536 - Misses 125 1448 +1323 - Partials 76 103 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Neo2308 commented 2 months ago

@acornett21 / @joelanford need help with this PR. How can we resolve the go-apidiff job failures?

acornett21 commented 2 months ago

Hi @Neo2308 please see my comment on this other PR.

https://github.com/operator-framework/helm-operator-plugins/pull/377#issuecomment-2297076776

acornett21 commented 1 month ago

This is no longer needed...closing.