search

operator-framework / helm-operator-plugins

Experimental refactoring of the operator-framework's helm operator
Apache License 2.0
49 stars 49 forks source link

reconciler: fix deletion wait and updater retry logic #380

Closed joelanford closed 1 month ago

joelanford commented 1 month ago

Fixes #378

acornett21 commented 1 month ago

@joelanford Would this also need to go into operator-sdk directly as well?

joelanford commented 1 month ago

@acornett21 The code bases are similar, but I can't remember if we have the same updater and wait for deletion logic there.

acornett21 commented 1 month ago

@joelanford ahh okay, I assumed this issue was coming from an operator, but now I see that stackrox has a direct dependencies on this lib. Just wanted to make sure we cover the bases.

porridge commented 1 month ago

@joelanford note the unhappy linter...

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (08ab7fb) to head (175bc01). Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/internal/updater/updater.go 78.94% 2 Missing and 2 partials :warning:

:exclamation: There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (175bc01). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (08ab7fb) | HEAD (175bc01) | |------|------|------| ||2|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #380 +/- ## ========================================== - Coverage 85.06% 79.67% -5.40% ========================================== Files 19 31 +12 Lines 1346 1958 +612 ========================================== + Hits 1145 1560 +415 - Misses 125 310 +185 - Partials 76 88 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.