Closed acornett21 closed 1 month ago
Attention: Patch coverage is 0%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 79.50%. Comparing base (
08ab7fb
) to head (f1c8352
). Report is 36 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
internal/cmd/root.go | 0.00% | 11 Missing :warning: |
internal/version/version.go | 0.00% | 2 Missing :warning: |
main.go | 0.00% | 1 Missing :warning: |
:exclamation: There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (f1c8352). Click for more details.
HEAD has 1 upload less than BASE
| Flag | BASE (08ab7fb) | HEAD (f1c8352) | |------|------|------| ||2|1|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Also, updated operator-controller
with a replaces
in the go.mod
file to make sure this does not break anything in operator-controller
, and in the open PR, all relevant tests pass.
Motivation
The adoption of the helm hybrid operator has been very low, even in official catalogs like OperatorHub, there are only three operators, all of which are person maintained, and not organization maintained. Another bennefit is that this enables dropped the
kubebuilder
dependency, and we'd no longer had to generate/scaffold these files prior to and after each release of this project. This alone reduces the maintance burden to upkeep the project, as an added bonus, releases becomepush a tag
.Changes
/hack
directory and the call to it in theMakefile
.hybrid cmd
.root
cmd, this enables the binary to function like a normal cobra built cli, and adds some cobra freebies as well.testutils
since there is no longer scaffolding, this is not needed.version
to be compatible with cobra.main
to call theroot
cmd.pkg/plugin
to remove the hybrid plugin.testdata
since this was the scaffoled/generated hybrid files.New Output
Other thoughts
I think this covers everything, but any change like this I realize is hard to review, and things might have been missed, since I do not have all the tribal knowledge about this project, so my ask to reviewers is to go through this with a fine tooth'd comb. Also, if there are ways of testing
run
let me know and happy to do that as well.