Closed timonwong closed 1 week ago
Nice catch! Although it feels like such issue should really be caught by unit tests. Could you maybe take a stab at adding such case?
sure! i'll then add a case for that
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.67%. Comparing base (
08ab7fb
) to head (abbabcb
). Report is 48 commits behind head on main.:exclamation: There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (abbabcb). Click for more details.
HEAD has 1 upload less than BASE
| Flag | BASE (08ab7fb) | HEAD (abbabcb) | |------|------|------| ||2|1|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Any particular reason why the Apply operation can't be done at the end of the function instead of in a defer clause?
Any particular reason why the Apply operation can't be done at the end of the function instead of in a defer clause?
Becasue the Apply() is for status update here. When early return (in case of error) from Reconcile loop, you need to set error conditions for your managed CR resources, the defer
approch is more ideal than:
goto
to handle them in a uniform wayApply
every time before return err