operator-framework / helm-operator-plugins

Experimental refactoring of the operator-framework's helm operator
Apache License 2.0
49 stars 49 forks source link

pkg/client: add history method to ActionClient #397

Closed joelanford closed 4 days ago

joelanford commented 4 days ago

In order to give users of this library more information about the state of a release, we are adding the History method to the ActionClient interface.

Without this, the only information available via the ActionClient about a release is the latest revision (via the Get method). However this proves insufficient if callers need to know details of release history, for example if an upgrade failed and callers want to know about the most recently deployed release.

codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.69%. Comparing base (08ab7fb) to head (e3aa77e). Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/internal/fake/actionclient.go 42.85% 3 Missing and 1 partial :warning:

:exclamation: There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (e3aa77e). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (08ab7fb) | HEAD (e3aa77e) | |------|------|------| ||2|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #397 +/- ## ========================================== - Coverage 85.06% 79.69% -5.37% ========================================== Files 19 31 +12 Lines 1346 1980 +634 ========================================== + Hits 1145 1578 +433 - Misses 125 313 +188 - Partials 76 89 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.