search

operator-framework / helm-operator-plugins

Experimental refactoring of the operator-framework's helm operator
Apache License 2.0
49 stars 49 forks source link

pkg/storage: handle more possible release label k/v pairs #399

Closed joelanford closed 1 day ago

joelanford commented 2 days ago

Release labels are currently stored only in Kubernetes object metadata, which limits what can actually be stored there.

In order to support a wider variety of release labels, we will only store system labels in the index secret. All custom release labels will be serialized in the release blob itself.

codecov-commenter commented 2 days ago

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.48%. Comparing base (08ab7fb) to head (cceec2e). Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
pkg/storage/chunked.go 91.17% 1 Missing and 2 partials :warning:

:exclamation: There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (cceec2e). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (08ab7fb) | HEAD (cceec2e) | |------|------|------| ||2|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #399 +/- ## ========================================== - Coverage 85.06% 78.48% -6.59% ========================================== Files 19 31 +12 Lines 1346 2477 +1131 ========================================== + Hits 1145 1944 +799 - Misses 125 444 +319 - Partials 76 89 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openshift-ci[bot] commented 2 days ago

New changes are detected. LGTM label has been removed.