search

operator-framework / java-operator-sdk

Java SDK for building Kubernetes Operators
https://javaoperatorsdk.io/
Apache License 2.0
807 stars 216 forks source link

improve: workflow builder naming #2559

Closed csviri closed 1 month ago

csviri commented 1 month ago

@metacosm a bit nit on naming, let me know if sounds better also to you ears :)

csviri commented 1 month ago

Was thining about more variation, I know how did you mean it but, just having the same wording as in annotations (where it makes sense) is a bit better IMO.

( https://github.com/operator-framework/java-operator-sdk/blob/1da6558a9f7804a2210a24e6d0400494e9911353/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/Dependent.java#L79 )

metacosm commented 1 month ago

I prefer the fluent version but using the same wording as the annotation attribute makes sense.