search

operator-framework / java-operator-sdk

Java SDK for building Kubernetes Operators
https://javaoperatorsdk.io/
Apache License 2.0
805 stars 216 forks source link

improve: mapping from annotation depends on type #2599

Closed csviri closed 15 hours ago

csviri commented 2 days ago

compiles

csviri commented 2 days ago

If this is merged, I will do a separate PR that improved on the API, namely that SecondaryToPrimary mapper will have a setter for primary type, so it can be set under the hood, so user won't have to do it.

openshift-merge-robot commented 2 days ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
xstefank commented 16 hours ago

@csviri some rebase went wrong :)

csviri commented 16 hours ago

@csviri some rebase went wrong :)

This happens when we reabase new PRs on next, but after the next is rebased again on main. Then only trivial solution is just (squash+) cherry-pick commits on a new branch. Maybe would be good to sync when we do rebases of next on top of main. Ideally if there are no complex PRs targeting next. cc @metacosm

csviri commented 15 hours ago

replaced by: https://github.com/operator-framework/java-operator-sdk/pull/2606