Closed kouk closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kouk
To complete the pull request process, please assign joelanford after the PR has been reviewed.
You can assign the PR to them by writing /assign @joelanford
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/assign @joelanford
Hi @kouk, I think the issue you were experiencing may have been solved by https://github.com/operator-framework/kubectl-operator/pull/80
On a build from main
, I retried your command and got this:
$ kubectl operator install cert-manager --channel stable --approval Automatic -n operators
subscription "cert-manager" created
operator "cert-manager" installed; installed csv is "cert-manager.v1.10.2"
I'm going to close this out since it looks like its fixed, but please open another issue or PR if you see something else missing!
thanks @joelanford I can't check it right now but seems legit.
The possibleInstallModes method doesn't deal with the special case of a target namespace being the empty string, so validation fails when installing to the global operator group. E.g.
Add a special method to determine the operator group's supported methods. Ref: https://olm.operatorframework.io/docs/concepts/crds/operatorgroup/#installmodes-and-supported-operatorgroups