search

operator-framework / kubectl-operator

Manage Kubernetes Operators from the command line
https://operatorframework.io/
Apache License 2.0
128 stars 37 forks source link

assets/demo: Use the eval built-in command for typed commands #74

Closed timflannagan closed 2 years ago

timflannagan commented 2 years ago

Use the eval built-in bash command to handle the typed command strings. This change should allow more complex commands that use pipe or redirect output.

Signed-off-by: timflannagan timflannagan@gmail.com

timflannagan commented 2 years ago

We don't have to merge this but it was just something I noticed locally in case others found it useful.

timflannagan commented 2 years ago

The go-apidiff check is failing - opened https://github.com/operator-framework/kubectl-operator/pull/74 which should hopefully fix that issue.

joelanford commented 2 years ago

/lgtm /approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operator-framework/kubectl-operator/blob/main/OWNERS)~~ [joelanford] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment